Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the raw checksum with b64 decoded checksum for GCS #5891

Merged
merged 1 commit into from Apr 11, 2023
Merged

Replace the raw checksum with b64 decoded checksum for GCS #5891

merged 1 commit into from Apr 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 11, 2023

Fixes #5874

Replace the raw checksum with b64 decoded checksum for GCS

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #5891 (68e2c72) into master (c773062) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head 68e2c72 differs from pull request most recent head 42bb525. Consider uploading reports for the commit 42bb525 to get more accurate results

@@            Coverage Diff             @@
##           master    #5891      +/-   ##
==========================================
- Coverage   88.83%   88.82%   -0.01%     
==========================================
  Files         162      162              
  Lines       11106    11108       +2     
  Branches     1805     1805              
==========================================
+ Hits         9866     9867       +1     
- Misses        959      960       +1     
  Partials      281      281              
Impacted Files Coverage Δ
scrapy/mail.py 77.77% <0.00%> (-0.88%) ⬇️
scrapy/pipelines/files.py 72.00% <50.00%> (+0.09%) ⬆️

@Gallaecio Gallaecio merged commit d47c732 into scrapy:master Apr 11, 2023
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrapy does not decode base64 MD5 checksum from GCS
2 participants