-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing for scrapy/core/downloader #5896
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5896 +/- ##
==========================================
- Coverage 88.82% 88.77% -0.06%
==========================================
Files 162 162
Lines 11129 11159 +30
Branches 1808 1813 +5
==========================================
+ Hits 9885 9906 +21
- Misses 961 966 +5
- Partials 283 287 +4
|
x509name_to_string(server_cert.get_issuer()), | ||
x509name_to_string(server_cert.get_subject()), | ||
) | ||
if server_cert: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth it! :)
def __repr__(self): | ||
return f"<{self.__class__.__name__}: {self.url}>" | ||
def __repr__(self) -> str: | ||
return f"<{self.__class__.__name__}: {self._url}>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
It doesn't seem worth it to add typing for code that uses Twisted HTTP stuff, as that code is itself untyped and also some of our code uses zope.interface which is not really supported by mypy.