-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Fix for #5855 #5898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #5855 #5898
Conversation
@tstauder First suggestion: review your changes as seen in your pull request, and make sure they only include intended changes. I see some commented out code that you probably used during debugging and should not be a part of this change. I also see a bad edit of a docstring. |
Codecov Report
@@ Coverage Diff @@
## master #5898 +/- ##
==========================================
- Coverage 88.82% 88.30% -0.53%
==========================================
Files 162 162
Lines 11129 11052 -77
Branches 1808 1637 -171
==========================================
- Hits 9885 9759 -126
- Misses 961 997 +36
- Partials 283 296 +13
|
test_batch_path_differ remove comments and fix docstring
Thanks for the helpful feedback. I cleaned up those issues and updated the pull request to include them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor issue I mention below, it looks good to me. Thanks!
Thanks! |
Changed batch_time to batch_id in test_batch_path_differ function in test_feedexport: #5855
Fixes #5855