-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs/intro/tutorial.rst checks #5902
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5902 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 162 162
Lines 11159 11165 +6
Branches 1813 1814 +1
=======================================
+ Hits 9906 9912 +6
Misses 966 966
Partials 287 287
|
I wonder what to do with pinned environments. Maybe we could skip doctests with pinned versions:
|
@Gallaecio I made the changes you mention, it seems that there are no more failures related to |
tox.ini
Outdated
@@ -152,7 +156,7 @@ basepython = {[testenv:pypy3]basepython} | |||
deps = | |||
{[pinned]deps} | |||
PyPyDispatcher==2.1.0 | |||
commands = {[testenv:pypy3]commands} | |||
commands = {[pinned]commands} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably OK before, testenv:pypy3
above does not use --doctest-modules
. I suspect this change may be responsible for the job failing now (maybe coverage breaks pypy?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, how strange it seems that now all the tests are passing, but I remember that one was failing.
Anyway, you're right. I'm going to undo this change. I see that previously the command did not use --doctest-modules
nor did it use coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I undid the change, but the test failed again. So I added a custom command for pypy3-pinned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that one was failing
I did re-run the failing test in case it was a random issue, but I did not expect it to pass 😅
Nice, thanks! |
Fix docs/intro/tutorial.rst checks:
command:
output: