-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the Parsel JMESPath feature #5915
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5915 +/- ##
==========================================
+ Coverage 88.77% 88.81% +0.03%
==========================================
Files 162 162
Lines 11165 11181 +16
Branches 1814 1818 +4
==========================================
+ Hits 9912 9930 +18
+ Misses 966 965 -1
+ Partials 287 286 -1
|
The test on pinned envs failed because those use the old parsel version. We want to make sure that Scrapy and user code continue working with old parsel. Can you please check and fix those issues, probably just by marking the tests |
I've checked the code and it doesn't make sure |
@wRAR I have updated the code, do you think it is necessary to make any other changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice work!
It would be great if we could also address #5903, as these 2 are the only Parsel-related changes blocking Scrapy 2.9, but we can handle that separately.
Thanks! |
Added support for
jmespath
Closes #5894