Skip to content

fix: non-UTF-8 content-type headers #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2023
Merged

fix: non-UTF-8 content-type headers #5917

merged 2 commits into from
May 2, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented May 2, 2023

Resolve #5914

Applied the proposed solution: #5914 (comment)

⚠️ Failed tests don't have anything to do with the change.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #5917 (4ad4159) into master (b50c032) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4ad4159 differs from pull request most recent head 7b49aa1. Consider uploading reports for the commit 7b49aa1 to get more accurate results

@@           Coverage Diff           @@
##           master    #5917   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files         162      162           
  Lines       11175    11175           
  Branches     1817     1817           
=======================================
  Hits         9922     9922           
  Misses        966      966           
  Partials      287      287           
Impacted Files Coverage Δ
scrapy/http/response/text.py 100.00% <100.00%> (ø)
scrapy/responsetypes.py 94.28% <100.00%> (ø)

@Gallaecio
Copy link
Member

⚠️ Failed tests don't have anything to do with the change.

feigns suprise

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@wRAR
Copy link
Member

wRAR commented May 2, 2023

Thanks!

@wRAR wRAR merged commit 6a169d4 into scrapy:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception with non-UTF-8 Content-Type
3 participants