Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle Parsel > 1.7.0 warning #5918

Merged
merged 2 commits into from
May 4, 2023
Merged

fix: Handle Parsel > 1.7.0 warning #5918

merged 2 commits into from
May 4, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented May 4, 2023

resolves: #5903

Please let me know if this is the best approach to handle this.

@Laerte Laerte changed the title fix: Handle Parsel warning fix: Handle Parsel >= 1.8.1 warning May 4, 2023
@Laerte Laerte changed the title fix: Handle Parsel >= 1.8.1 warning fix: Handle Parsel > 1.7.0 warning May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #5918 (8501d64) into master (ea15ff1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8501d64 differs from pull request most recent head 7317ff1. Consider uploading reports for the commit 7317ff1 to get more accurate results

@@           Coverage Diff           @@
##           master    #5918   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files         162      162           
  Lines       11181    11184    +3     
  Branches     1818     1819    +1     
=======================================
+ Hits         9930     9933    +3     
  Misses        965      965           
  Partials      286      286           
Impacted Files Coverage Δ
scrapy/selector/unified.py 100.00% <100.00%> (ø)

@wRAR wRAR merged commit 776cf59 into scrapy:master May 4, 2023
@wRAR
Copy link
Member

wRAR commented May 4, 2023

Thanks!
We can address the potential optimization improvements separately, together with already filed #5906.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning: Selector got both text and root, root is being ignored. WARNING
4 participants