Skip to content

Configurable exception list retry middleware 2701 #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 16, 2023

Conversation

serhii73
Copy link
Collaborator

@serhii73 serhii73 commented May 9, 2023

Resolves #2701, closes #2984, closes #3334.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #5929 (f0ba2b9) into master (52c0726) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head f0ba2b9 differs from pull request most recent head 9aaa0eb. Consider uploading reports for the commit 9aaa0eb to get more accurate results

@@            Coverage Diff             @@
##           master    #5929      +/-   ##
==========================================
+ Coverage   88.81%   88.87%   +0.05%     
==========================================
  Files         162      162              
  Lines       11184    11206      +22     
  Branches     1819     1825       +6     
==========================================
+ Hits         9933     9959      +26     
+ Misses        965      962       -3     
+ Partials      286      285       -1     
Impacted Files Coverage Δ
scrapy/utils/defer.py 97.31% <ø> (ø)
scrapy/downloadermiddlewares/retry.py 100.00% <100.00%> (ø)
scrapy/exporters.py 100.00% <100.00%> (ø)
scrapy/extensions/feedexport.py 95.80% <100.00%> (+0.16%) ⬆️
scrapy/settings/default_settings.py 98.77% <100.00%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes

@serhii73 serhii73 requested review from Gallaecio and wRAR May 9, 2023 15:40
@wRAR wRAR added this to the Scrapy 2.10 milestone May 10, 2023
serhii73 and others added 5 commits May 10, 2023 22:10
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
serhii73 and others added 2 commits May 17, 2023 18:27
Co-authored-by: Adrián Chaves <adrian@chaves.io>
serhii73 and others added 2 commits June 4, 2023 11:50
Co-authored-by: Adrián Chaves <adrian@chaves.io>
@Gallaecio
Copy link
Member

Niiice!

@Gallaecio Gallaecio merged commit 777a6ea into master Jun 16, 2023
@wRAR wRAR deleted the configurable-exception-list-retry-middleware-2701 branch June 16, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Exceptions Handled by Retry Middleware Configurable
5 participants