Skip to content

Actually run test_set_asyncio_event_loop(). #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Jun 14, 2023

The test added in #5832 was never actually run. It was also broken.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #5951 (627187b) into master (d2e7f6e) will not change coverage.
The diff coverage is n/a.

❗ Current head 627187b differs from pull request most recent head 7cfdca8. Consider uploading reports for the commit 7cfdca8 to get more accurate results

@@           Coverage Diff           @@
##           master    #5951   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         162      162           
  Lines       11199    11199           
  Branches     1821     1821           
=======================================
  Hits         9952     9952           
  Misses        962      962           
  Partials      285      285           

@wRAR wRAR merged commit bc09c9e into scrapy:master Jun 14, 2023
@wRAR wRAR deleted the fix-asyncio-loop-test branch June 14, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants