Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg_resources usage #5958

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Remove pkg_resources usage #5958

merged 6 commits into from
Jun 21, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Jun 20, 2023

Fix #5956

Removed code for checking setup_tools version since we are checking for a version from 2015

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #5958 (f22f882) into master (fae5538) will increase coverage by 46.48%.
The diff coverage is 50.00%.

❗ Current head f22f882 differs from pull request most recent head 82cf00b. Consider uploading reports for the commit 82cf00b to get more accurate results

@@             Coverage Diff             @@
##           master    #5958       +/-   ##
===========================================
+ Coverage   42.36%   88.84%   +46.48%     
===========================================
  Files         162      162               
  Lines       11206    11206               
  Branches     1825     1825               
===========================================
+ Hits         4747     9956     +5209     
+ Misses       6103      965     -5138     
+ Partials      356      285       -71     
Impacted Files Coverage Δ
scrapy/cmdline.py 67.96% <50.00%> (+67.96%) ⬆️

... and 140 files with indirect coverage changes

@Laerte Laerte requested review from Gallaecio and wRAR June 20, 2023 21:57
@Laerte Laerte self-assigned this Jun 20, 2023
Copy link
Member

@wRAR wRAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wRAR wRAR merged commit e9e1034 into scrapy:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pkg_resources usage
3 participants