Skip to content

fix: Return value instead of SettingsAttribute object when using pop method #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Jun 27, 2023

As reported on #5959 (comment), the implementation of pop method is returning SettingsAttribute object instead of the value itself which break interface. Mea culpa, sorry! 😅

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #5963 (a252597) into master (5105742) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head a252597 differs from pull request most recent head 90cfbd1. Consider uploading reports for the commit 90cfbd1 to get more accurate results

@@            Coverage Diff             @@
##           master    #5963      +/-   ##
==========================================
- Coverage   89.19%   89.12%   -0.08%     
==========================================
  Files         162      162              
  Lines       11287    11287              
  Branches     1833     1833              
==========================================
- Hits        10067    10059       -8     
- Misses        928      934       +6     
- Partials      292      294       +2     
Impacted Files Coverage Δ
scrapy/settings/__init__.py 98.34% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Laerte Laerte added the bug label Jun 27, 2023
@Laerte Laerte requested review from wRAR and Gallaecio June 27, 2023 22:29
@Gallaecio Gallaecio merged commit b619630 into scrapy:master Jun 28, 2023
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants