Removing hard code entries #5965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
reviewed
Jul 5, 2023
| scrapy_module = os.environ.get("SCRAPY_SETTINGS_MODULE") | ||
| if scrapy_module is not None: | ||
| scrapy_module = os.environ.get(ENVVAR) | ||
| if scrapy_module: |
There was a problem hiding this comment.
This is a change in behavior when the SCRAPY_SETTINGS_MODULE is set to an empty string. That said, an empty string cannot work here, so I guess it is fine and slightly improves readability, so +1 from me.
There was a problem hiding this comment.
Yeaaaaah!!!! =]
Gallaecio
approved these changes
Jul 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #5965 +/- ##
==========================================
- Coverage 89.19% 89.12% -0.08%
==========================================
Files 162 162
Lines 11287 11287
Branches 1833 1833
==========================================
- Hits 10067 10059 -8
- Misses 928 934 +6
- Partials 292 294 +2
|
wRAR
approved these changes
Jul 5, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just removing hard code statements