Skip to content

fix: -O/-o option does not work with absolute paths on Windows #5971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: -O/-o option does not work with absolute paths on Windows #5971

merged 2 commits into from
Jul 24, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Jul 11, 2023

fix #5969

@Laerte Laerte requested review from Gallaecio and wRAR July 11, 2023 03:50
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #5971 (161c3b8) into master (8055a94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 161c3b8 differs from pull request most recent head 4bd3060. Consider uploading reports for the commit 4bd3060 to get more accurate results

@@           Coverage Diff           @@
##           master    #5971   +/-   ##
=======================================
  Coverage   89.19%   89.19%           
=======================================
  Files         162      162           
  Lines       11287    11288    +1     
  Branches     1833     1833           
=======================================
+ Hits        10067    10068    +1     
  Misses        928      928           
  Partials      292      292
Impacted Files Coverage Δ
scrapy/extensions/feedexport.py 95.82% <100.00%> (ø)
scrapy/utils/conf.py 92.30% <100.00%> (+0.06%) ⬆️

wRAR
wRAR reviewed Jul 14, 2023
View reviewed changes
@Laerte Laerte added the bug label Jul 17, 2023
@Laerte
Copy link
Member Author

Laerte commented Jul 21, 2023

@Gallaecio Can we merge it?

Gallaecio
Gallaecio approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks, and sorry for the delay.

@Gallaecio Gallaecio merged commit 7522aee into scrapy:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

@Gallaecio Gallaecio Gallaecio approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crawl -o and -O options does not work with absolute paths on Windows
3 participants
@Laerte @wRAR @Gallaecio