-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove functions deprecated in 2.6.0 #5996
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5996 +/- ##
==========================================
- Coverage 89.23% 89.21% -0.02%
==========================================
Files 163 162 -1
Lines 11370 11350 -20
Branches 1844 1843 -1
==========================================
- Hits 10146 10126 -20
Misses 930 930
Partials 294 294
|
I expected that we do, yeah. Do you think it's problematic? |
@wRAR Not at all! I will handle the leftover later then, i was just making sure, thanks man! |
@wRAR Seems something went off when we deprecated parameters from engine (is running for 4 hours already), can you please cancel the queued runs? 😅 My last commit reverts this change so i can take a look in a separate PR. |
Thanks @wRAR I will raise another PR to deprecate the spider parameter from engine soon as i understand what went off. |
The only deprecated logic that i didn't remove was:- #5090Because seems a little be tricky (should we remove the deprecated parameters?) 😄I will commit the removal of #5090 logic later on in this PR.