Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove functions deprecated in 2.6.0 #5996

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Remove functions deprecated in 2.6.0 #5996

merged 6 commits into from
Aug 3, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Aug 2, 2023

The only deprecated logic that i didn't remove was:
- #5090

Because seems a little be tricky (should we remove the deprecated parameters?) 😄

I will commit the removal of #5090 logic later on in this PR.

@Laerte Laerte self-assigned this Aug 2, 2023
@Laerte Laerte added the cleanup label Aug 2, 2023
@Laerte Laerte requested review from wRAR and Gallaecio August 2, 2023 12:26
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #5996 (b112c72) into master (7c6aaed) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head b112c72 differs from pull request most recent head 4ac7485. Consider uploading reports for the commit 4ac7485 to get more accurate results

@@            Coverage Diff             @@
##           master    #5996      +/-   ##
==========================================
- Coverage   89.23%   89.21%   -0.02%     
==========================================
  Files         163      162       -1     
  Lines       11370    11350      -20     
  Branches     1844     1843       -1     
==========================================
- Hits        10146    10126      -20     
  Misses        930      930              
  Partials      294      294              
Files Changed Coverage Δ
scrapy/extensions/feedexport.py 95.61% <ø> (-0.04%) ⬇️
scrapy/squeues.py 100.00% <ø> (ø)

@wRAR
Copy link
Member

wRAR commented Aug 2, 2023

should we remove the deprecated parameters?

I expected that we do, yeah. Do you think it's problematic?

@Laerte
Copy link
Member Author

Laerte commented Aug 2, 2023

@wRAR Not at all! I will handle the leftover later then, i was just making sure, thanks man!

@Laerte
Copy link
Member Author

Laerte commented Aug 2, 2023

@wRAR Seems something went off when we deprecated parameters from engine (is running for 4 hours already), can you please cancel the queued runs? 😅 My last commit reverts this change so i can take a look in a separate PR.

@wRAR wRAR closed this Aug 2, 2023
@wRAR wRAR reopened this Aug 2, 2023
@Laerte
Copy link
Member Author

Laerte commented Aug 2, 2023

Thanks @wRAR I will raise another PR to deprecate the spider parameter from engine soon as i understand what went off.

@Gallaecio Gallaecio merged commit b9c32a0 into scrapy:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants