Skip to content

Remove deprecated spider parameter from engine #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Remove deprecated spider parameter from engine #5998

merged 2 commits into from
Aug 4, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Aug 3, 2023

Close #5994

@Laerte Laerte changed the title Deprecate spider parameter from engine Deprecate spider parameter from engine Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #5998 (beab756) into master (b9c32a0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head beab756 differs from pull request most recent head 4ff23d4. Consider uploading reports for the commit 4ff23d4 to get more accurate results

@@            Coverage Diff             @@
##           master    #5998      +/-   ##
==========================================
+ Coverage   89.21%   89.24%   +0.02%     
==========================================
  Files         162      162              
  Lines       11350    11325      -25     
  Branches     1843     1835       -8     
==========================================
- Hits        10126    10107      -19     
+ Misses        930      927       -3     
+ Partials      294      291       -3     
Files Changed Coverage Δ
scrapy/core/engine.py 85.21% <100.00%> (+0.81%) ⬆️

@Laerte Laerte requested review from wRAR and Gallaecio August 3, 2023 20:48
@Laerte Laerte self-assigned this Aug 3, 2023
@Laerte Laerte added the cleanup label Aug 3, 2023
@wRAR wRAR changed the title Deprecate spider parameter from engine Remove deprecated spider parameter from engine Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove things deprecated in 2.6.0
3 participants