Skip to content

More typing for scrapy/*.py #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 11, 2023
Merged

More typing for scrapy/*.py #6005

merged 11 commits into from
Aug 11, 2023

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Aug 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #6005 (6834f4a) into master (34d050c) will decrease coverage by 0.15%.
The diff coverage is 82.20%.

❗ Current head 6834f4a differs from pull request most recent head 8a0108b. Consider uploading reports for the commit 8a0108b to get more accurate results

@@            Coverage Diff             @@
##           master    #6005      +/-   ##
==========================================
- Coverage   89.07%   88.92%   -0.15%     
==========================================
  Files         162      162              
  Lines       11412    11443      +31     
  Branches     1853     1860       +7     
==========================================
+ Hits        10165    10176      +11     
- Misses        949      962      +13     
- Partials      298      305       +7     
Files Changed Coverage Δ
scrapy/logformatter.py 88.63% <50.00%> (-6.37%) ⬇️
scrapy/middleware.py 93.22% <57.14%> (-4.97%) ⬇️
scrapy/dupefilters.py 82.71% <60.00%> (-3.36%) ⬇️
scrapy/core/scheduler.py 91.97% <66.66%> (-1.27%) ⬇️
scrapy/utils/request.py 95.41% <66.66%> (-0.68%) ⬇️
scrapy/spiderloader.py 96.36% <75.00%> (-3.64%) ⬇️
scrapy/link.py 89.47% <81.81%> (-10.53%) ⬇️
scrapy/responsetypes.py 91.78% <86.66%> (-2.51%) ⬇️
scrapy/spiders/__init__.py 93.75% <89.47%> (-2.92%) ⬇️
scrapy/core/scraper.py 85.02% <100.00%> (+0.08%) ⬆️
... and 2 more

@wRAR wRAR merged commit 7c49768 into scrapy:master Aug 11, 2023
@wRAR wRAR deleted the typing-crawler branch August 11, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants