Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated PythonItemExporter.binary #6007

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Remove deprecated PythonItemExporter.binary #6007

merged 1 commit into from
Aug 10, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Aug 9, 2023

Closes #6006

@Laerte Laerte self-assigned this Aug 9, 2023
@Laerte Laerte requested review from wRAR and Gallaecio August 9, 2023 21:10
@Laerte Laerte added the cleanup label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #6007 (9a5f9d2) into master (85696d7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9a5f9d2 differs from pull request most recent head 04b6529. Consider uploading reports for the commit 04b6529 to get more accurate results

@@            Coverage Diff             @@
##           master    #6007      +/-   ##
==========================================
- Coverage   89.08%   89.07%   -0.01%     
==========================================
  Files         162      162              
  Lines       11425    11416       -9     
  Branches     1856     1854       -2     
==========================================
- Hits        10178    10169       -9     
  Misses        949      949              
  Partials      298      298              
Files Changed Coverage Δ
scrapy/exporters.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated PythonItemExporter.binary
3 participants