Skip to content

Handle Tuple type on getdictorlist method, bump 3.12 python version #6013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Handle Tuple type on getdictorlist method, bump 3.12 python version #6013

merged 1 commit into from
Aug 14, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Aug 13, 2023

fix #6011

@Laerte Laerte requested review from Gallaecio and wRAR August 13, 2023 06:45
@Laerte Laerte self-assigned this Aug 13, 2023
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #6013 (eca9ca8) into master (7c49768) will decrease coverage by 0.83%.
The diff coverage is 100.00%.

❗ Current head eca9ca8 differs from pull request most recent head b06936f. Consider uploading reports for the commit b06936f to get more accurate results

@@            Coverage Diff             @@
##           master    #6013      +/-   ##
==========================================
- Coverage   88.92%   88.09%   -0.83%     
==========================================
  Files         162      162              
  Lines       11443    11445       +2     
  Branches     1860     1861       +1     
==========================================
- Hits        10176    10083      -93     
- Misses        962     1059      +97     
+ Partials      305      303       -2     
Files Changed Coverage Δ
scrapy/settings/__init__.py 95.45% <100.00%> (+0.04%) ⬆️

... and 14 files with indirect coverage changes

@wRAR
Copy link
Member

wRAR commented Aug 13, 2023

I don't understand why do some tests fail :-/

@wRAR
Copy link
Member

wRAR commented Aug 13, 2023

So it looks like the 3.12.0-beta.4 extra-deps test failure is guaranteed, I'd try to debug it locally (you should be able to get 3.12 with pyenv)

@Laerte
Copy link
Member Author

Laerte commented Aug 13, 2023

So it looks like the 3.12.0-beta.4 extra-deps test failure is guaranteed, I'd try to debug it locally (you should be able to get 3.12 with pyenv)

I did some testings, in the end separating into another test solved the issue, i also bumped the version of 3.12 on CI to Release Candidate.

@Laerte Laerte changed the title chore: Handle Set/Tuple types on getdictorlist method Handle Set/Tuple types on getdictorlist method Aug 13, 2023
@Laerte Laerte changed the title Handle Set/Tuple types on getdictorlist method Handle Tuple type on getdictorlist method Aug 14, 2023
Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Laerte Laerte changed the title Handle Tuple type on getdictorlist method Handle Tuple type on getdictorlist method, bump 3.12 python version Aug 14, 2023
@wRAR wRAR merged commit 3318971 into scrapy:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError scrapy.settings in getdictorlist
3 participants