-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Handle Tuple type on getdictorlist method, bump 3.12 python version #6013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6013 +/- ##
==========================================
- Coverage 88.92% 88.09% -0.83%
==========================================
Files 162 162
Lines 11443 11445 +2
Branches 1860 1861 +1
==========================================
- Hits 10176 10083 -93
- Misses 962 1059 +97
+ Partials 305 303 -2
|
I don't understand why do some tests fail :-/ |
So it looks like the 3.12.0-beta.4 extra-deps test failure is guaranteed, I'd try to debug it locally (you should be able to get 3.12 with pyenv) |
I did some testings, in the end separating into another test solved the issue, i also bumped the version of 3.12 on CI to Release Candidate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
fix #6011