Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type hints for Twisted 23.8.0. #6034

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Aug 31, 2023

Fixes #6031

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #6034 (4c35863) into master (a320e5f) will decrease coverage by 0.33%.
Report is 69 commits behind head on master.
The diff coverage is 85.83%.

❗ Current head 4c35863 differs from pull request most recent head 94af8d0. Consider uploading reports for the commit 94af8d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6034      +/-   ##
==========================================
- Coverage   89.24%   88.92%   -0.33%     
==========================================
  Files         162      163       +1     
  Lines       11325    11536     +211     
  Branches     1835     1876      +41     
==========================================
+ Hits        10107    10258     +151     
- Misses        927      969      +42     
- Partials      291      309      +18     
Files Changed Coverage Δ
scrapy/linkextractors/__init__.py 100.00% <ø> (ø)
scrapy/logformatter.py 88.63% <50.00%> (-6.37%) ⬇️
scrapy/middleware.py 93.22% <57.14%> (-4.97%) ⬇️
scrapy/contracts/__init__.py 82.22% <60.00%> (-1.38%) ⬇️
scrapy/dupefilters.py 82.71% <60.00%> (-3.36%) ⬇️
scrapy/core/scheduler.py 91.97% <66.66%> (-1.27%) ⬇️
scrapy/utils/request.py 95.41% <66.66%> (-0.68%) ⬇️
scrapy/utils/trackref.py 76.92% <66.66%> (-6.42%) ⬇️
scrapy/utils/spider.py 75.00% <71.42%> (-5.00%) ⬇️
scrapy/http/response/text.py 98.42% <80.00%> (-1.58%) ⬇️
... and 32 more

@Gallaecio Gallaecio merged commit 276bce0 into scrapy:master Sep 1, 2023
@wRAR wRAR deleted the typing-new-twisted branch September 1, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update type hints for Twisted 23.8.0 changes
2 participants