Skip to content

Improve the backwards compatibility for RetryMiddleware.EXCEPTIONS_TO_RETRY #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Sep 14, 2023

Fixes #6049 (with the code provided by the reporter)

@wRAR wRAR added the bug label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #6050 (431fb01) into master (dba3767) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 431fb01 differs from pull request most recent head 800c1f1. Consider uploading reports for the commit 800c1f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6050      +/-   ##
==========================================
- Coverage   88.95%   88.88%   -0.07%     
==========================================
  Files         163      163              
  Lines       11567    11571       +4     
  Branches     1877     1876       -1     
==========================================
- Hits        10289    10285       -4     
- Misses        969      975       +6     
- Partials      309      311       +2     
Files Changed Coverage Δ
scrapy/downloadermiddlewares/retry.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@wRAR wRAR merged commit 3f34a5b into scrapy:master Sep 15, 2023
@wRAR wRAR deleted the retrymw-fix branch September 15, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants