Skip to content

#6056 Issue: Updated news.rst #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2023
Merged

#6056 Issue: Updated news.rst #6061

merged 3 commits into from
Sep 22, 2023

Conversation

yash08123
Copy link
Contributor

@yash08123 yash08123 commented Sep 21, 2023

Updated the docs with the scrapy.utils.boto.is_botocore() function is removed at 2.8.0 release note.

Fixes #6056

@yash08123 yash08123 changed the title Updated the docs #6056 Issue: Updated news.rst Sep 21, 2023
@yash08123 yash08123 closed this Sep 22, 2023
@yash08123 yash08123 reopened this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #6061 (a4fdc36) into master (9bfe0de) will not change coverage.
The diff coverage is n/a.

❗ Current head a4fdc36 differs from pull request most recent head b08079a. Consider uploading reports for the commit b08079a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6061   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         163      163           
  Lines       11571    11571           
  Branches     1876     1876           
=======================================
  Hits        10293    10293           
  Misses        969      969           
  Partials      309      309           

@Gallaecio Gallaecio self-requested a review September 22, 2023 08:10
@Gallaecio Gallaecio merged commit 908da8b into scrapy:master Sep 22, 2023
@Gallaecio
Copy link
Member

Thanks!

@yash08123
Copy link
Contributor Author

Thank you for your assistance @wRAR . It was my first time contributing to an open source project. Thank you for instructing me.

@wRAR
Copy link
Member

wRAR commented Sep 22, 2023

@yash08123 congratulations :)

@yash08123 yash08123 deleted the Doc_Edit branch September 23, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropping is_botocore wasn't documented
3 participants