Update httperror.py #612
Merged
Update httperror.py #612
Conversation
Log ignored HTTP pages when the response code is not allowed or not configured to be handled.
|
Thanks! |
|
This doesn't look good, the logging should happen on |
|
Whoops! I'll fix that. |
kmike
added a commit
to kmike/scrapy
that referenced
this pull request
Mar 18, 2014
dangra
added a commit
that referenced
this pull request
Mar 19, 2014
[MRG] Fix for #612 + small tests cleanup
chekunkov
added a commit
to chekunkov/scrapy
that referenced
this pull request
Apr 26, 2014
Digenis
added a commit
to Digenis/scrapy
that referenced
this pull request
May 6, 2015
Conflicts: scrapy/tests/test_spidermiddleware_httperror.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Log ignored HTTP pages when the response code is not allowed or not configured to be handled.