Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update httperror.py #612

Merged
merged 1 commit into from Mar 18, 2014
Merged

Update httperror.py #612

merged 1 commit into from Mar 18, 2014

Conversation

@deed02392
Copy link
Contributor

@deed02392 deed02392 commented Feb 24, 2014

Log ignored HTTP pages when the response code is not allowed or not configured to be handled.

Log ignored HTTP pages when the response code is not allowed or not configured to be handled.
@kmike
Copy link
Member

@kmike kmike commented Mar 18, 2014

Thanks!

kmike added a commit that referenced this pull request Mar 18, 2014
Update httperror.py
@kmike kmike merged commit 9edbb68 into scrapy:master Mar 18, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@dangra
Copy link
Member

@dangra dangra commented Mar 18, 2014

This doesn't look good, the logging should happen on process_spider_exception() hook, after the spider had a chance to handle the HttpError on request's errback function.

@kmike
Copy link
Member

@kmike kmike commented Mar 18, 2014

Whoops! I'll fix that.

kmike added a commit to kmike/scrapy that referenced this pull request Mar 18, 2014
dangra added a commit that referenced this pull request Mar 19, 2014
[MRG] Fix for #612 + small tests cleanup
chekunkov added a commit to chekunkov/scrapy that referenced this pull request Apr 26, 2014
Digenis added a commit to Digenis/scrapy that referenced this pull request May 6, 2015
Conflicts:
	scrapy/tests/test_spidermiddleware_httperror.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.