Selectorlist extract first #624

Closed
wants to merge 7 commits into
from

Projects

None yet

5 participants

@ananana
ananana commented Mar 4, 2014

Fixed failed tests in pull request #572 that adds extract_first() method to SelectorList; related to original issue #568

@shaneaevans
Member

code looks ok 👍

@kmike kmike commented on the diff Apr 15, 2014
scrapy/selector/unified.py
@@ -169,9 +169,17 @@ def css(self, xpath):
def re(self, regex):
return flatten([x.re(regex) for x in self])
+ def re_first(self, regex):
+ for el in iflatten((x.re(regex) for x in self)):
@kmike
kmike Apr 15, 2014 Scrapy project member

iflatten(x.re(regex) for x in self) should also work

@curita
Member
curita commented Mar 13, 2015

@ananana hi! Sorry for such late follow up, we're planning on (finally) getting this pull request merged.

There are some tasks still needed for doing so.
First, we should rebase current changes from scrapy:master. I tried to do it but there were some conflicts, maybe it's best to start a new pull requests and cherry-pick commits from this pull request.

Second, last commit (0587132) is a merge, it'd be best if it wasn't, we use merge commits for merging pull requests, so it's preferred that all commits from a given pull request are simple commits.

Are you interested in making these changes? Let us know, we can implement them if that's not the case.

@curita
Member
curita commented Mar 19, 2015

Merged in ff64584

@curita curita closed this Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment