Fixed failed tests in pull request #572 that adds extract_first() method to SelectorList; related to original issue #568
Add extract_first() method to SelectorList
Add tests to extract_first()
Add docs for extract_first()
Fix extract_first() docs
Add re_first() to SelectorList and iflatten() to utils.python
Merge branch 'selectorlist-extract-first' of github.com:shirk3y/scrap…
…y into selectorlist-extract-first
code looks ok 👍
iflatten(x.re(regex) for x in self) should also work
iflatten(x.re(regex) for x in self)
@ananana hi! Sorry for such late follow up, we're planning on (finally) getting this pull request merged.
There are some tasks still needed for doing so.
First, we should rebase current changes from scrapy:master. I tried to do it but there were some conflicts, maybe it's best to start a new pull requests and cherry-pick commits from this pull request.
Second, last commit (0587132) is a merge, it'd be best if it wasn't, we use merge commits for merging pull requests, so it's preferred that all commits from a given pull request are simple commits.
Are you interested in making these changes? Let us know, we can implement them if that's not the case.
Merge branch 'ananana-selectorlist-extract-first' from pull request #624
Merged in ff64584