Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted sep-001 to rst format #630

Merged
merged 2 commits into from Mar 7, 2014
Merged

Conversation

@aspidites
Copy link
Contributor

@aspidites aspidites commented Mar 6, 2014

Began implementing #629

-----------------

ItemForm
~~~~~~~~

This comment has been minimized.

@aspidites

aspidites Mar 6, 2014
Author Contributor

Wasn't sure what was currently being used for level 3 headers.

--------

Pros:
- same API used for Items (see http://doc.scrapy.org/en/latest/topics/items.html)

This comment has been minimized.

@aspidites

aspidites Mar 6, 2014
Author Contributor

The original link (http://doc.scrapy.org/experimental/topics/newitem/index.html#more-advanced-items) was broken, and I couldn't find an archived version of it. If this new page references something entirely, I should probably consider reverting to the old link to remain historically accurate.

This comment has been minimized.

@pablohoffman

pablohoffman Mar 7, 2014
Member

either is fine for me, it'd be broken either way

pablohoffman added a commit that referenced this pull request Mar 7, 2014
Converted sep-001 to rst format
@pablohoffman pablohoffman merged commit 690081b into scrapy:master Mar 7, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@aspidites aspidites deleted the aspidites:sep-001.rst branch Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.