Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for FormRequest.from_response clickdata parameter #645

Merged
merged 2 commits into from Mar 13, 2014

Conversation

@curita
Copy link
Member

@curita curita commented Mar 12, 2014

Fixes #427

Documentation about:

  • clickdata parameter in Formrequest.from_response
  • nr attribute in clickdata dict
  • default behaviour when clickdata is None
curita added 2 commits Mar 12, 2014
Documentation about:
 * clickdata parameter in Formrequest.from_response
 * nr attribute in clickdata dict
 * default behaviour when clickdata is None
Clickdata doc enhancements:
 * Fix xml attributes mention
 * nr is 0-indexed reference
@@ -303,6 +303,13 @@ fields with form data from :class:`Response` objects.
overridden by the one passed in this parameter.
:type formdata: dict

:param clickdata: attributes to lookup the control clicked. If it's not
given, the form data will be submitted simulating a click on the
first clickable element. In addition to xml attributes, the control

This comment has been minimized.

@dangra

dangra Mar 12, 2014
Member

Commonly speaking the controls are from HTML forms, not XML.
Also worth mentioning nr is 0 indexed.

@dangra
Copy link
Member

@dangra dangra commented Mar 12, 2014

this is great! thanks for taking the time to improve FormRequest docs.

@curita
Copy link
Member Author

@curita curita commented Mar 13, 2014

@dagra Changes that you suggested have been pushed :)

dangra added a commit that referenced this pull request Mar 13, 2014
Documentation for FormRequest.from_response clickdata parameter
@dangra dangra merged commit f921d2a into scrapy:master Mar 13, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@dangra
Copy link
Member

@dangra dangra commented Mar 13, 2014

thanks

@curita curita deleted the curita:formrequest-clickdata-doc branch Mar 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants