Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for clickdata's nr index in FormRequest #646

Merged
merged 2 commits into from Mar 13, 2014

Conversation

@curita
Copy link
Member

@curita curita commented Mar 12, 2014

Test valid and invalid nr value.

req = self.request_class.from_response(response, clickdata={'nr': 1})
fs = _qs(req)
self.assertTrue('clickable2' in fs, fs)
self.assertFalse('clickable1' in fs, fs)

This comment has been minimized.

@dangra

dangra Mar 12, 2014
Member

assertIn() and assertNotIn() are preferred

@curita
Copy link
Member Author

@curita curita commented Mar 13, 2014

I fixed it.

dangra added a commit that referenced this pull request Mar 13, 2014
Tests for clickdata's nr index in FormRequest
@dangra dangra merged commit c2fd1f8 into scrapy:master Mar 13, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@curita curita deleted the curita:formrequest-clickdata-nr-index-tests branch Mar 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants