Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link in docs/topics/architecture.rst #647

Closed
wants to merge 3 commits into from
Closed

Conversation

@coder46
Copy link
Contributor

@coder46 coder46 commented Mar 12, 2014

No description provided.

@coder46
Copy link
Contributor Author

@coder46 coder46 commented Mar 12, 2014

@shane42 Please review this.

@shaneaevans
Copy link
Member

@shaneaevans shaneaevans commented Mar 14, 2014

I think that link is likely to get outdated. I wonder if we should just delete it instead? or maybe there's another (current) place to link to, or other useful docs/tutorials?

@coder46
Copy link
Contributor Author

@coder46 coder46 commented Mar 22, 2014

@shane42 I think this resource is pretty good http://krondo.com/blog/?page_id=1327
Should I add this ?

@kmike
Copy link
Member

@kmike kmike commented Apr 15, 2014

I like the krondo link, +1 for merging.

@dangra
Copy link
Member

@dangra dangra commented Apr 21, 2014

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Apr 24, 2014

Let's just add the Krondo link to the list?

I'd also remove " - Krondo" from the title and just leave it "Twisted Introduction" since "Krondo" is an unknown and irrelevant term there.

@coder46
Copy link
Contributor Author

@coder46 coder46 commented Apr 24, 2014

@pablohoffman updated architecture.rst
coder46@5a247c5

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Apr 24, 2014

thanks @coder46 - you should rebase to master due to #687

@dangra
Copy link
Member

@dangra dangra commented Jun 3, 2014

@coder46 do you mind squashing your commits and rebasing on top of master? I'm cool if you don't have the time. thanks!

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jul 22, 2014

@dangra Do we still want this link?

@dangra
Copy link
Member

@dangra dangra commented Jul 22, 2014

the broken link was fixed by the link in this PR is looks very useful and could be nice to include it somehow in our docs.

@kmike kmike added the docs label Mar 13, 2015
@kmike
Copy link
Member

@kmike kmike commented Mar 13, 2015

Adding it to Scrapy 1.0 as a part of docs improving effort.

@kmike kmike added this to the Scrapy 1.0 milestone Mar 13, 2015
@curita
Copy link
Member

@curita curita commented Mar 19, 2015

Merged in 67a85c7

@curita curita closed this Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants