for loops have to have a : at the end of the line #675

ncp1113 · 2014-03-31T20:14:44Z

changed 3 instances

kmike · 2014-03-31T20:18:09Z

.. and these doctests are not proper doctests: correct spelling for

>>> for p in divs.xpath('//p'):
>>>     print p.extract()

is

>>> for p in divs.xpath('//p'):
...     print p.extract()

As you're into it, maybe you could fix this as well? Thanks!

for loops have to have a : at the end of the line

dangra · 2014-04-24T18:35:03Z

needs to be ported to trunk, the PR was for 0.22 branch.

kmike · 2014-04-24T18:35:39Z

Yep, see 5f18816

dangra · 2014-04-24T18:35:40Z

ah sorry, already done.

kmike · 2014-04-24T18:37:23Z

I think it was submitted against 0.22 because of "Edit on GitHub" link at http://doc.scrapy.org

for loops have to have a : at the end of the line

Loading status checks…

1380e41

changed 3 instances

kmike added a commit that referenced this pull request Apr 24, 2014

Merge pull request #675 from ncp1113/patch-1

Loading status checks…

a96a21e

for loops have to have a : at the end of the line

kmike merged commit a96a21e into scrapy:0.22 Apr 24, 2014
1 check failed

1 check failed

default The Travis CI build failed
Details

scrapy / scrapy

for loops have to have a : at the end of the line #675

for loops have to have a : at the end of the line #675

ncp1113 commented Mar 31, 2014

kmike commented Mar 31, 2014

dangra commented Apr 24, 2014

kmike commented Apr 24, 2014

dangra commented Apr 24, 2014

kmike commented Apr 24, 2014

scrapy / scrapy

for loops have to have a : at the end of the line #675

for loops have to have a : at the end of the line #675

Conversation

ncp1113 commented Mar 31, 2014

kmike commented Mar 31, 2014

dangra commented Apr 24, 2014

kmike commented Apr 24, 2014

dangra commented Apr 24, 2014

kmike commented Apr 24, 2014