Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for loops have to have a : at the end of the line #675

Merged
merged 1 commit into from Apr 24, 2014
Merged

Conversation

@ncp1113
Copy link
Contributor

@ncp1113 ncp1113 commented Mar 31, 2014

changed 3 instances

changed 3 instances
@kmike
Copy link
Member

@kmike kmike commented Mar 31, 2014

.. and these doctests are not proper doctests: correct spelling for

>>> for p in divs.xpath('//p'):
>>>     print p.extract()

is

>>> for p in divs.xpath('//p'):
...     print p.extract()

As you're into it, maybe you could fix this as well? Thanks!

kmike added a commit that referenced this pull request Apr 24, 2014
for loops have to have a : at the end of the line
@kmike kmike merged commit a96a21e into scrapy:0.22 Apr 24, 2014
1 check failed
1 check failed
default The Travis CI build failed
Details
@dangra
Copy link
Member

@dangra dangra commented Apr 24, 2014

needs to be ported to trunk, the PR was for 0.22 branch.

@kmike
Copy link
Member

@kmike kmike commented Apr 24, 2014

Yep, see 5f18816

@dangra
Copy link
Member

@dangra dangra commented Apr 24, 2014

ah sorry, already done.

@kmike
Copy link
Member

@kmike kmike commented Apr 24, 2014

I think it was submitted against 0.22 because of "Edit on GitHub" link at http://doc.scrapy.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants