[MRG] Toplevel Shortcuts #684
Merged
Conversation
…witching to py.test. py.test replaces AssertionError exception with its own subclass in an import hook. For some reason when top-level shortcuts were added "except AssertionError" in contracts.__init__ meant "except py.test AssertionError" while scrapy.exceptions.ContractFail was still a subclass of a builtin AssertionError, so Contracts reported errors instead of failures and this made tests in test_contracts.py fail. For now - just disable fancy py.test asserts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a rebased version of #577 without ItemLoader promotion.
TODO: