Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Toplevel Shortcuts #684

Merged
merged 6 commits into from Apr 24, 2014
Merged

Conversation

@kmike
Copy link
Member

@kmike kmike commented Apr 8, 2014

This is a rebased version of #577 without ItemLoader promotion.

TODO:

  • investigate why tests fail and fix them.
@kmike kmike changed the title [WIP] Toplevel Shortcuts [MRG] Toplevel Shortcuts Apr 8, 2014
@kmike kmike changed the title [MRG] Toplevel Shortcuts [WIP] Toplevel Shortcuts Apr 10, 2014
dangra and others added 6 commits Jan 22, 2014
…witching to py.test.

py.test replaces AssertionError exception with its own subclass in an import hook.
For some reason when top-level shortcuts were added "except AssertionError" in
contracts.__init__ meant "except py.test AssertionError" while scrapy.exceptions.ContractFail
was still a subclass of a builtin AssertionError, so Contracts reported errors
instead of failures and this made tests in test_contracts.py fail.

For now - just disable fancy py.test asserts.
@kmike kmike changed the title [WIP] Toplevel Shortcuts [MRG] Toplevel Shortcuts Apr 15, 2014
@dangra dangra merged commit c3426e9 into scrapy:master Apr 24, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@dangra dangra mentioned this pull request Jun 25, 2014
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants