Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scrapy.version_info when SCRAPY_VERSION_FROM_GIT is set #692

Merged
merged 1 commit into from Apr 17, 2014

Conversation

@kmike
Copy link
Member

@kmike kmike commented Apr 16, 2014

Previously it failed with the following exception with SCRAPY_VERSION_FROM_GIT set:

version_info = tuple(int(v) for v in __version__.split('.')[:3])
ValueError: invalid literal for int() with base 10: '0-189-g7814cbf' 

After this fix __version__ parts that can't be converted to int will be left as strings, e.g. (0, 23, '0-189-g7814cbf').

@shaneaevans
Copy link
Member

@shaneaevans shaneaevans commented Apr 16, 2014

👍 - this should fix the problem we were seeing

kmike added a commit that referenced this pull request Apr 17, 2014
fix scrapy.version_info when SCRAPY_VERSION_FROM_GIT is set
@kmike kmike merged commit e482c6e into scrapy:master Apr 17, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@kmike kmike deleted the kmike:version_info_fix branch Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants