Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-spider settings and api cleanup: sep#19 update #705

Merged
merged 1 commit into from May 4, 2014

Conversation

@curita
Copy link
Member

@curita curita commented Apr 25, 2014

I'm submitting the update of sep#19 that I proposed on GSoC.

Changes in the previous version of this sep were detailed and extended with implementation suggestions, backward compatibility concerns and issues that may arise.

There are no substantial modifications with the repository version of the proposal, except a tentative SettingsLoader and SettingsReader interaction using a method that freezes the former into an instance of the latter. I'm not satisfied with that approach as it introduces a lot of overhead to settings modification and crawling using the API on users' side. For example, crawlers are created with an instance of the reader class, but if users want to modify settings they can only do this in a loader instance, this distinction is not practical and seems a little inconsistent. Between this options I rather keep a single Settings class and try to distinguish loader and reader tasks in another way if that's really necessary.

These months I'll be coding those features/refactors based on this document, so early feedback is greatly appreciate it.

dangra added a commit that referenced this pull request May 4, 2014
Per-spider settings and api cleanup: sep#19 update
@dangra dangra merged commit 4bd8eb1 into scrapy:master May 4, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@curita curita deleted the curita:sep19-update branch May 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.