set the exit code to non-zero when contracts fails #727
Conversation
|
+1 but use existent support to return custom exitcode by setting self.exitcode to desired valud instead of abruptly exiting. |
|
thanks @tpeng , can you squash the commits as last request? |
dangra
added a commit
that referenced
this pull request
May 21, 2014
set the exit code to non-zero when contracts fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
it's can be handy to to tell the CI that the scrapy contract test failed.