Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the exit code to non-zero when contracts fails #727

Merged
merged 1 commit into from May 21, 2014

Conversation

@tpeng
Copy link
Contributor

@tpeng tpeng commented May 20, 2014

it's can be handy to to tell the CI that the scrapy contract test failed.

@dangra
Copy link
Member

@dangra dangra commented May 20, 2014

+1 but use existent support to return custom exitcode by setting self.exitcode to desired valud instead of abruptly exiting.

@dangra
Copy link
Member

@dangra dangra commented May 20, 2014

thanks @tpeng , can you squash the commits as last request?

dangra added a commit that referenced this pull request May 21, 2014
set the exit code to non-zero when contracts fails
@dangra dangra merged commit 156d347 into scrapy:master May 21, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.