Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings api cleanup #737

Merged
merged 15 commits into from Jun 25, 2014
Merged

Settings api cleanup #737

merged 15 commits into from Jun 25, 2014

Conversation

@curita
Copy link
Member

@curita curita commented May 28, 2014

Progress so far on the settings api changes of the GSoC project.

  • Settings new api
    • Settings priorities
    • Backward compatibility support
    • Testing
    • Documentation
    • Interface unification across code

Settings freeze support and per-spider settings will be implemented on separate pull requests.

@curita curita changed the title [WIP] Settings api cleanup Settings api cleanup Jun 10, 2014
@curita
Copy link
Member Author

@curita curita commented Jun 10, 2014

I've completed this pull request, and I'll be working on further changes based on these ones on my local repo until they are reviewed.

@dangra
Copy link
Member

@dangra dangra commented Jun 12, 2014

Great! I'll review them soon.

@dangra dangra mentioned this pull request Jun 24, 2014
@dangra
Copy link
Member

@dangra dangra commented Jun 25, 2014

hi @curita, this PR looks perfect, I was about to merge it for 0.24 but realized it doesn't offer backwards compatibility for deprecated settings.overrides. I see CrawlerSettings is deprecated but the settings object passed around is a Settings instance instead, so custom project commands or systems boostraping the crawl programmatically will raise AttributeError trying to override settings the old way.

@dangra dangra merged commit 6730e3c into scrapy:master Jun 25, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
dangra added a commit that referenced this pull request Jun 25, 2014
Settings api cleanup
@dangra
Copy link
Member

@dangra dangra commented Jun 25, 2014

I merged the PR after restoring .overrides attribute compatibility in f224ac1.

Thanks for the great work @curita!, now I am anxious to see the following tasks in this GSoC project implemented.

@curita
Copy link
Member Author

@curita curita commented Jun 25, 2014

Thanks @dangra for fixing it! I'm sorry i couldn't work on it sooner.

@curita curita deleted the curita:settings-cleanup branch Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.