Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloader setting #738

Merged
merged 2 commits into from Jun 3, 2014
Merged

Downloader setting #738

merged 2 commits into from Jun 3, 2014

Conversation

@chekunkov
Copy link
Contributor

@chekunkov chekunkov commented Jun 2, 2014

I need the ability to use custom Downloader class for one of the projects, so please tell if we can merge this PR

@dangra
Copy link
Member

@dangra dangra commented Jun 2, 2014

LGTM.

We have a setting like this to set the scheduler, makes sense to have one for downloader although we don't promise backward compatibility in internal APIs.

@chekunkov
Copy link
Contributor Author

@chekunkov chekunkov commented Jun 2, 2014

We have a setting like this to set the scheduler, makes sense to have one

yep, I've made this PR by analogy with the SCHEDULER setting

although we don't promise backward compatibility in internal APIs.

sure, I understand that. Scheduler is an internal API as well (if my understanding is correct) an the latter applies to it too

dangra added a commit that referenced this pull request Jun 3, 2014
Downloader setting
@dangra dangra merged commit 2a42c1c into scrapy:master Jun 3, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.