Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show all the missing field when scrapes contract fails #766

Closed
wants to merge 1 commit into from

Conversation

tpeng
Copy link
Contributor

@tpeng tpeng commented Jun 26, 2014

No description provided.

raise ContractFail("'%s' field is missing" % arg)
missing = [arg for arg in self.args if arg not in x]
if missing:
raise ContractFail("'%s' field is missing" % " ".join(missing))
Copy link
Contributor

@alexcepoi alexcepoi Jun 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this output 'name addres phone' field is missing?

otherwise +1

Copy link
Member

@dangra dangra Jun 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and a new/updated test case.

otherwise +1.

@Gallaecio
Copy link
Member

Gallaecio commented Aug 5, 2019

Continued at #3939.

@Gallaecio Gallaecio closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants