Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "sflo" local variables to less cryptic "log_observer" #775

Merged
merged 1 commit into from Jul 2, 2014

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jul 2, 2014

Hey,

I was reading Crawler source code, encountered "sflo" local variable and had no idea what is it. What do you think about renaming it to "log_observer"?

dangra added a commit that referenced this pull request Jul 2, 2014
rename "sflo" local variables to less cryptic "log_observer"
@dangra dangra merged commit e87dc37 into scrapy:master Jul 2, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Jul 2, 2014

an acronym for ScrapyFileLogObserver of course!. Isn't that obvious? :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants