PY3 make it possible to run some tests in Python3 #776
+13
−7
Conversation
Member
kmike
commented
Jul 2, 2014
|
* switch to Twisted 14.0.0 because SVN version broke twisted.log in Python 3; * skip top-level shortcuts to make at least some tests pass; * use PY3 compatible import of _monkeypatches.
| from scrapy.selector import Selector | ||
| from scrapy.item import Item, Field | ||
|
|
||
| del sys |
pablohoffman
Jul 2, 2014
Member
just curious, why do we delete sys? (I know it was done before)
just curious, why do we delete sys? (I know it was done before)
kmike
Jul 2, 2014
Author
Member
This is to make dir(scrapy) cleaner: __all__ affects only import *.
This is to make dir(scrapy) cleaner: __all__ affects only import *.
pablohoffman
Jul 2, 2014
Member
got it!
got it!
pablohoffman
added a commit
that referenced
this pull request
Jul 2, 2014
PY3 make it possible to run some tests in Python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.