Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PY3 make it possible to run some tests in Python3 #776

Merged
merged 1 commit into from Jul 2, 2014

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jul 2, 2014

  • switch to Twisted 14.0.0 because SVN version broke twisted.log in Python 3;
  • skip top-level shortcuts to make at least some tests pass;
  • use PY3 compatible import of _monkeypatches.
* switch to Twisted 14.0.0 because SVN version broke twisted.log in Python 3;
* skip top-level shortcuts to make at least some tests pass;
* use PY3 compatible import of _monkeypatches.
from scrapy.selector import Selector
from scrapy.item import Item, Field

del sys

This comment has been minimized.

@pablohoffman

pablohoffman Jul 2, 2014
Member

just curious, why do we delete sys? (I know it was done before)

This comment has been minimized.

@kmike

kmike Jul 2, 2014
Author Member

This is to make dir(scrapy) cleaner: __all__ affects only import *.

This comment has been minimized.

pablohoffman added a commit that referenced this pull request Jul 2, 2014
PY3 make it possible to run some tests in Python3
@pablohoffman pablohoffman merged commit 4b17aa2 into scrapy:master Jul 2, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants