Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referer to "Spider error processing" log message #795

Merged

Conversation

@chekunkov
Copy link
Contributor

@chekunkov chekunkov commented Jul 11, 2014

+ fixed some pep8 issues

Motivation: I want to be able to see response request referer in cases like this one:

selection_009

Also I wonder if messages like "Spider error processing", "Error downloading" etc. should be handled by logformatter - to make it possible to override/disable them.

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Oct 7, 2014

what do you think about this one @dangra?

@dangra
Copy link
Member

@dangra dangra commented Oct 7, 2014

pep8 + referer-in-error-message? Good to merge for me if nobody dissagree.

pablohoffman added a commit that referenced this pull request Oct 7, 2014
Add referer to "Spider error processing" log message
@pablohoffman pablohoffman merged commit aa61f61 into scrapy:master Oct 7, 2014
1 check passed
1 check passed
@nramirezuy
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants