Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For consistency, use `job_dir` helper in `SpiderState` extension. #805

Merged
merged 1 commit into from Jul 16, 2014

Conversation

@rmax
Copy link
Contributor

@rmax rmax commented Jul 16, 2014

The SpiderState extension is the only place not using the job_dir
helper.

This might cause an error in case JOBDIR is a nested path which does not
exists, although this is least likely by default given the job dir being
set up earlier.

The `SpiderState` extension is the only place not using the `job_dir`
helper.

This might cause an error in case JOBDIR is a nested path which does not
exists, although this is least likely by default given the job dir being
set up earlier.
pablohoffman added a commit that referenced this pull request Jul 16, 2014
For consistency, use `job_dir` helper in `SpiderState` extension.
@pablohoffman pablohoffman merged commit a17d417 into scrapy:master Jul 16, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.