Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] httpcache dont_cache meta #19 #689 #821

Merged
merged 1 commit into from Mar 17, 2015

Conversation

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jul 28, 2014

Implementation of: #19 #689

I think doing it on the middleware is the best, because it handle it for all the policies.

@kmike
Copy link
Member

@kmike kmike commented Jul 29, 2014

What about dont_cache=False?

@nramirezuy
Copy link
Contributor Author

@nramirezuy nramirezuy commented Jul 29, 2014

@kmike it doesn't work on any in any middleaware.

@kmike
Copy link
Member

@kmike kmike commented Jul 29, 2014

A good catch. But I think it is a bad behaviour. I've opened a ticket to discuss it.

@kmike
Copy link
Member

@kmike kmike commented Aug 29, 2014

+1 to this feature; the patch looks good except for the following:

  1. other middlewares now accept False values (see #846), so it is better to change it here as well;
  2. docs are missing.
@tonal
Copy link

@tonal tonal commented Oct 10, 2014

see also #918

@kmike
Copy link
Member

@kmike kmike commented Mar 13, 2015

Ping @nramirezuy :) It is an useful feature, and it is almost ready.

@nramirezuy nramirezuy force-pushed the nramirezuy:httpcache_dont_cache-19-689 branch 3 times, most recently from ebb0a0e to fb0ec2d Mar 16, 2015
@nramirezuy
Copy link
Contributor Author

@nramirezuy nramirezuy commented Mar 16, 2015

@kmike is that doc enough? or there are other places to change?

@nramirezuy nramirezuy changed the title [WIP] httpcache dont_cache meta #19 #689 [MRG] httpcache dont_cache meta #19 #689 Mar 16, 2015
@nramirezuy nramirezuy force-pushed the nramirezuy:httpcache_dont_cache-19-689 branch from fb0ec2d to c13e236 Mar 16, 2015
@nramirezuy
Copy link
Contributor Author

@nramirezuy nramirezuy commented Mar 16, 2015

@kmike done

@kmike kmike changed the title [MRG] httpcache dont_cache meta #19 #689 [MRG+1] httpcache dont_cache meta #19 #689 Mar 16, 2015
@kmike
Copy link
Member

@kmike kmike commented Mar 16, 2015

👍

pablohoffman added a commit that referenced this pull request Mar 17, 2015
[MRG+1] httpcache dont_cache meta #19 #689
@pablohoffman pablohoffman merged commit b461c6f into scrapy:master Mar 17, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@coveralls
Copy link

@coveralls coveralls commented Oct 26, 2016

Coverage Status

Changes Unknown when pulling c13e236 on nramirezuy:httpcache_dont_cache-19-689 into * on scrapy:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants