Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Test cases under project root dir #827

Merged
merged 8 commits into from Jul 31, 2014
Merged

Conversation

@dangra
Copy link
Member

@dangra dangra commented Jul 30, 2014

This PR aims to reduce the size of the releases uploaded to pypi, and also acknowledge that running tests isn't possible with default Scrapy requirements, so it doesn't make sense to ship them to final installations anymore.

After this changes the source distribution is 85% its previous size (636KB vs 750KB), and the Wheel distribution is 57% its previous size (280KB vs 491KB)

from scrapy.tests.spiders import FollowAllSpider
from scrapy.tests.mockserver import MockServer
from tests.spiders import FollowAllSpider
from tests.mockserver import MockServer
Copy link
Member

@kmike kmike Jul 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it won't work when "scrapy bench" is executed by users.

Copy link
Member Author

@dangra dangra Jul 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. I'll fix.

dangra added a commit that referenced this issue Jul 31, 2014
Move Test cases under project root dir
@dangra dangra merged commit 8d1f267 into scrapy:master Jul 31, 2014
1 check passed
@@ -4,7 +4,7 @@
# and then run "tox" from this directory.

[tox]
envlist = py27, pypy, precise, trunk, py33, docs
envlist = py27
Copy link
Member

@kmike kmike Jul 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to keep a list of environments users should test against (py27, precise, trunk, py33).

@kmike kmike mentioned this pull request Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants