Prevent Python 3 port regressions #830
Merged
Conversation
|
Running tests under Python 3 looks like this: $ tox -e py34
GLOB sdist-make: /home/daniel/src/scrapy/setup.py
py34 inst-nodeps: /home/daniel/src/scrapy/.tox/dist/Scrapy-0.25.1.zip
py34 runtests: PYTHONHASHSEED='3018538168'
py34 runtests: commands[0] | py.test tests
===================================== test session starts =====================================
platform linux -- Python 3.4.1 -- py-1.4.22 -- pytest-2.6.0
plugins: twisted
collected 41 items
tests/test_contrib_spiderstate.py ..
tests/test_dependencies.py .
tests/test_item.py ............
tests/test_urlparse_monkeypatches.py .
tests/test_utils_datatypes.py ...........
tests/test_utils_deprecate.py .............
tests/test_utils_http.py .
================================== 41 passed in 2.21 seconds ==================================
___________________________________________ summary ___________________________________________
py34: commands succeeded
congratulations :) |
|
Great! So I could now add more porting on a test-based strategy :) |
dangra
added a commit
that referenced
this pull request
Jul 31, 2014
[WIP] Prevent Python 3 port regressions
dangra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
WARNING This PR is developed on top of #827, the only change worth reviewing is 3f7f157Lot of people have made an effort to make Scrapy codebase Python3 compatible, but new changes needs manual review and sometimes new features or bugfixes are merged without considering Python3 compatibility.
This PR aims to minimize the regressions and to document what areas are pending to be migrated by collecting the list of yet to be migrated testcases at tests/py3-ignores.txt.
New test files are required to be python3 compatible or explicitly added to the ignore list.
/cc @kmike @felixonmars