Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Python 3 port regressions #830

Merged
merged 1 commit into from Jul 31, 2014
Merged

Prevent Python 3 port regressions #830

merged 1 commit into from Jul 31, 2014

Conversation

@dangra
Copy link
Member

@dangra dangra commented Jul 31, 2014

WARNING This PR is developed on top of #827, the only change worth reviewing is 3f7f157

Lot of people have made an effort to make Scrapy codebase Python3 compatible, but new changes needs manual review and sometimes new features or bugfixes are merged without considering Python3 compatibility.

This PR aims to minimize the regressions and to document what areas are pending to be migrated by collecting the list of yet to be migrated testcases at tests/py3-ignores.txt.

New test files are required to be python3 compatible or explicitly added to the ignore list.

/cc @kmike @felixonmars

@dangra
Copy link
Member Author

@dangra dangra commented Jul 31, 2014

Running tests under Python 3 looks like this:

$ tox -e py34
GLOB sdist-make: /home/daniel/src/scrapy/setup.py
py34 inst-nodeps: /home/daniel/src/scrapy/.tox/dist/Scrapy-0.25.1.zip
py34 runtests: PYTHONHASHSEED='3018538168'
py34 runtests: commands[0] | py.test tests
===================================== test session starts =====================================
platform linux -- Python 3.4.1 -- py-1.4.22 -- pytest-2.6.0
plugins: twisted
collected 41 items 

tests/test_contrib_spiderstate.py ..
tests/test_dependencies.py .
tests/test_item.py ............
tests/test_urlparse_monkeypatches.py .
tests/test_utils_datatypes.py ...........
tests/test_utils_deprecate.py .............
tests/test_utils_http.py .

================================== 41 passed in 2.21 seconds ==================================
___________________________________________ summary ___________________________________________
  py34: commands succeeded
  congratulations :)
@felixonmars
Copy link
Contributor

@felixonmars felixonmars commented Jul 31, 2014

Great! So I could now add more porting on a test-based strategy :)

dangra added a commit that referenced this pull request Jul 31, 2014
[WIP] Prevent Python 3 port regressions
@dangra dangra merged commit d89fc50 into scrapy:master Jul 31, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@dangra dangra changed the title [WIP] Prevent Python 3 port regressions Prevent Python 3 port regressions Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.