Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dont_merge_cookies bad behaviour when set to false on meta #846

Merged
merged 1 commit into from Aug 18, 2014

Conversation

@rocioar
Copy link
Contributor

@rocioar rocioar commented Aug 8, 2014

No description provided.

@kmike
Copy link
Member

@kmike kmike commented Aug 10, 2014

+1 to this change, but I'd prefer to fix it all at once to make it consistent (see #825), and this PR needs tests and docs.

@rocioar
Copy link
Contributor Author

@rocioar rocioar commented Aug 10, 2014

I agree. I can work on that.

@kmike
Copy link
Member

@kmike kmike commented Aug 15, 2014

LGTM

dangra added a commit that referenced this pull request Aug 18, 2014
fix dont_merge_cookies bad behaviour when set to false on meta
@dangra dangra merged commit d684eca into scrapy:master Aug 18, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.