GSoC Per-spider settings #854
Conversation
@dangra I've fixed both issues and rebased the new changes in the api-cleanup pull request on this branch. |
This comment has been minimized.
This comment has been minimized.
sorry for been late, but I think RuntimeError is better than TypeError in this case, the latter is much more common mistake. @kmike what do you think? |
This comment has been minimized.
This comment has been minimized.
I suggested TypeError because this is what immutable containers raise, e.g.
|
This comment has been minimized.
This comment has been minimized.
ok, fair point :)
…On Thu, Aug 14, 2014 at 2:34 PM, Mikhail Korobov ***@***.*** wrote:
I suggested TypeError because this is what immutable containers raise, e.g.
## In [1]: (3,2)[0] = 1
TypeError Traceback (most recent call last)
<ipython-input-1-cab3fa073914> in <module>()
----> 1 (3,2)[0] = 1
TypeError: 'tuple' object does not support item assignment
—
Reply to this email directly or view it on GitHub
70f2010#commitcomment-7393006
.
|
def spiders(self): | ||
if not hasattr(self, '_spiders'): | ||
warnings.warn("Crawler.spiders is deprecated, use " | ||
"CrawlerRunner.spiders or instantiate " |
kmike
Aug 14, 2014
Member
It seems that CrawlerRunner.spiders is not documented. I'm not sure I like that CrawlerSpider knows about SpiderManager (and it can be used without it, as shown in your new example).
It seems that CrawlerRunner.spiders is not documented. I'm not sure I like that CrawlerSpider knows about SpiderManager (and it can be used without it, as shown in your new example).
Merged by 5daa147 |
This comment has been minimized.
This comment has been minimized.
This comment should be removed or changed to: # 'testspider' is the name... |
This comment has been minimized.
This comment has been minimized.
Not sure if I'm misunderstanding what you're saying @raintan, but |
This comment has been minimized.
This comment has been minimized.
In the latest version of the docs, followall isn't part of the code example anymore. |
This comment has been minimized.
This comment has been minimized.
Oh, I see what you meant, thanks for the notice! This issue seems to be fixed already (that's why these docs are correct), but the latest available version of scrapy docs is this one: http://doc.scrapy.org/en/master/topics/practices.html (I know, rather confusing that is not Generally opening an issue for any kind of bugs is the way to go, it's more flexible and github offers more features for them (can be referenced easier, we can modify their status to track the work done on them, milestones can be assigned to each of them, etc), so feel free to open an issue for your next bug report :) |
Per-spider settings task of the 2014 GSoC, implemented on top of the #816 pull request.
This changes are based on the SEP#19.