Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix xmliter namespace on selected node #861

Closed
wants to merge 1 commit into from

Conversation

nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Aug 19, 2014

This PR was triggered by scrapy-users

Actually xmliter populates a Selector with everything from the position 0 to the tag start, so if we had 100mb before the tag we want to iter it copy those 100mb across all the Selector objects. Also it just extract this info for the first tag and embed the rest on that, this can cause info crossing.

In this PR I kept the regex stuff even tho I think we should use something like iterparse.

Currently xmliter_lxml tests are failing due to it has a different API.

@kmike
Copy link
Member

kmike commented Aug 29, 2014

+1 to iterparse

@pablohoffman
Copy link
Member

pablohoffman commented Oct 29, 2014

what's left for this WIP to become MRG?

@nramirezuy
Copy link
Contributor Author

nramirezuy commented Oct 29, 2014

@pablohoffman Know if we keep this approach or we move to iterparse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants