Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated deprecated cgi.parse_qsl to use six's parse_qsl #909

Merged
merged 1 commit into from Oct 3, 2014

Conversation

@VKen
Copy link
Contributor

@VKen VKen commented Oct 2, 2014

According to Python 2 documentation: https://docs.python.org/2/library/cgi.html#cgi.parse_qsl

"This function is deprecated in this module. Use urlparse.parse_qsl() instead. It is maintained here only for backward compatiblity."

For future compatibility with Python 3, the scrapy.utils.url module is updated to use six library's urllib.parse.parse_qsl instead.
https://pythonhosted.org/six/#module-six.moves.urllib.parse

@kmike
Copy link
Member

@kmike kmike commented Oct 3, 2014

Thanks!

kmike added a commit that referenced this pull request Oct 3, 2014
updated deprecated cgi.parse_qsl to use six's parse_qsl
@kmike kmike merged commit 14957ed into scrapy:master Oct 3, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants