Drop old engine code #911
Merged
Drop old engine code #911
Conversation
* remove Downloader import unused since 1fba64 * remove CONCURRENT_SPIDERS deprecation warning from a1dbc6 (2011)
|
+1. Your PR is better because it cleans up imports. |
|
@kmike I found it while researching your answer in the scrapylib PR, so bonus goes to you ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I think we might clean this up, that was 0.12 in 2011