Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old engine code #911

Merged
merged 1 commit into from Oct 3, 2014
Merged

Drop old engine code #911

merged 1 commit into from Oct 3, 2014

Conversation

@nyov
Copy link
Contributor

@nyov nyov commented Oct 3, 2014

I think we might clean this up, that was 0.12 in 2011

  * remove Downloader import unused since 1fba64
  * remove CONCURRENT_SPIDERS deprecation warning from a1dbc6 (2011)
@kmike
Copy link
Member

@kmike kmike commented Oct 3, 2014

+1.

Your PR is better because it cleans up imports.

pablohoffman added a commit that referenced this pull request Oct 3, 2014
Drop old engine code
@pablohoffman pablohoffman merged commit 5f1bbe2 into scrapy:master Oct 3, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@nyov nyov deleted the nyov:nyov/dev branch Oct 3, 2014
@nyov
Copy link
Contributor Author

@nyov nyov commented Oct 3, 2014

@kmike I found it while researching your answer in the scrapylib PR, so bonus goes to you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.