Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted bin folder from root, fixes #913 #914

Merged
merged 1 commit into from Oct 9, 2014
Merged

Conversation

@brunsgaard
Copy link
Contributor

@brunsgaard brunsgaard commented Oct 7, 2014

Pretty trivial, but fixes #913.

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Oct 7, 2014

Can you tell us why this is a fix?

@brunsgaard
Copy link
Contributor Author

@brunsgaard brunsgaard commented Oct 7, 2014

@nramirezuy What? It just removes the bin folder and #913 is an issue about removing the bin folder?

I don't think I understand what you are asking? Could you be more clear?

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Oct 7, 2014

I'm using that file in my virtualenvs. I have a single "installation" (master branch) of scrapy and I link that file to the every project bin, so I don't have to update every project to the production version.

@brunsgaard
Copy link
Contributor Author

@brunsgaard brunsgaard commented Oct 7, 2014

@nramirezuy You could achieve the same thing using python setup.py develop, right?
Also, if you did. You would not have to customize $PYTHONPATH, which I guess you have modified to make your little setup thingy working. And manually copy over the script. Seems like unnecessary work, when python setup.py develop does it all for you.. (and for everybody else that have a similar need) In my opinion this would be the right way to do it these days.. ;)

Take a look at the docs if you are not acquainted with the setuptools development mode.

@kmike What do you think?

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Oct 7, 2014

I'm just using virtualenvwrapper.

A cool thing about my approach, is that I can do changes to scrapy(this includes fetching branches) code and use it on an actual project.

@brunsgaard
Copy link
Contributor Author

@brunsgaard brunsgaard commented Oct 7, 2014

Have you read the documentation? python setup.py develop does the same thing, right?
You can make changes to the scrapy code, check out new branches.. and it all takes effect in your
projects right away... Read the docs, and do best practice.. :)

@dangra
Copy link
Member

@dangra dangra commented Oct 7, 2014

I second @brunsgaard, not sure I understand why it doesn't work for you @nramirezuy

@brunsgaard
Copy link
Contributor Author

@brunsgaard brunsgaard commented Oct 9, 2014

@dangra @nramirezuy What is needed to move forward?

@dangra
Copy link
Member

@dangra dangra commented Oct 9, 2014

waiting for @nramirez or other maintainers to share his views. I am not a
user of bin/scrapy myself and I am used to "pip install -e" for the
packages I use in develop mode. If time passes I will just merge.

On Thu, Oct 9, 2014 at 1:59 AM, Jonas Brunsgaard notifications@github.com
wrote:

@dangra https://github.com/dangra @nramirezuy
https://github.com/nramirezuy What is needed to move forward?


Reply to this email directly or view it on GitHub
#914 (comment).

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Oct 9, 2014

@dangra merge it if you like, I'll do copies instead of links for backwards compatibility (:

@kmike
Copy link
Member

@kmike kmike commented Oct 9, 2014

@nramirezuy I don't quite get it: do you symlink scrapy binary without installing scrapy in virtualenvs, and this works? Or do you install scrapy in each virtualenv by symlinking its source + the scrapy script manually?

We can add support for python -m scrapy, so there won't be a need to symlink binaries if Scrapy is installed. But as others said in you have Scrapy installed you already have scrapy in a proper place.

dangra added a commit that referenced this pull request Oct 9, 2014
Deleted bin folder from root, fixes #913
@dangra dangra merged commit 44cbbec into scrapy:master Oct 9, 2014
1 check passed
1 check passed
@nramirezuy
continuous-integration/travis-ci The Travis CI build passed
Details
@brunsgaard
Copy link
Contributor Author

@brunsgaard brunsgaard commented Oct 9, 2014

@kmike, My guess is that he has modified PYTHONPATH to include a version of scrapy. This way he can avoid installing scrapy in each virtualenv, he only needs to copy the binary in.

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Oct 9, 2014

@kmike I make a egg link to the source with add2virtualenv from virtualenvwrapper and then I create a symbolic link in the virtualenv bin folder to the binary that is in the source.

@kmike
Copy link
Member

@kmike kmike commented Oct 9, 2014

@nramirezuy looks like if you use python setup.py develop instead of add2virtualenv it will just work.

@kmike
Copy link
Member

@kmike kmike commented Oct 9, 2014

@brunsgaard AFAIK virtualenv overwrites PYTHONPATH, so modifications to it are discarded when you activate the virtualenv.

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Oct 9, 2014

@dangra The directory wasn't removed, just the file inside it (:

@kmike
Copy link
Member

@kmike kmike commented Oct 9, 2014

@nramirezuy git doesn't track folders, so you can't remove a directory by a commit. If you remove your local copy and clone the repo from scratch bin folder won't be there.

@dangra
Copy link
Member

@dangra dangra commented Oct 9, 2014

@dangra The directory wasn't removed, just the file inside it (:
@nramirezuy git doesn't track folders, so you can't remove a directory by a commit. If you remove your local copy and clone the repo from scratch bin folder won't be there.

or run git clean -dfq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants