[MRG+1] CSS support in link extractors #983
Merged
Conversation
|
I like this feature. My only concern is backwards compatibility: a new option is inserted in the middle, so user code that uses positional arguments will be broken. Using positional arguments is a bad style when list of arguments is long, but we're using it in Scrapy code ourselves (see super() calls). +1 to merge this PR after converting link extractor super() calls to use keyword arguments. |
… for backwards compatibility, use keyword arguments in link extractor super().__init__() calls
|
I have moved the new argument to the end, and changed the link extractor classes to use keyword arguments in |
|
It seems the Travis CI build has failed because of a timeout somewhere not related to my changes. |
kmike
changed the title
|
Looks good to me, +1 to merge. |
pablohoffman
added a commit
that referenced
this pull request
Mar 17, 2015
[MRG+1] CSS support in link extractors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This adds support for using CSS selectors in link extractors.