Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1]Pydispatch pep8 #992

Merged
merged 1 commit into from Mar 17, 2015
Merged

[MRG+1]Pydispatch pep8 #992

merged 1 commit into from Mar 17, 2015

Conversation

@chekunkov
Copy link
Contributor

@chekunkov chekunkov commented Dec 26, 2014

Tabs to spaces, proper number of blank lines between imports, classes and methods

@kmike
Copy link
Member

@kmike kmike commented Mar 13, 2015

The long-term plan is to drop bundled pydispatch copy. I wonder if it make sense to do such changes to it.

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Mar 16, 2015

@chekunkov Already wasted time doing it, and merging it won't harm anyone. I will just suggest to sqash and rename commit to make allusion to pydispatch.

@chekunkov
Copy link
Contributor Author

@chekunkov chekunkov commented Mar 16, 2015

@kmike some plans are too long-term :) I was reading that code and fix costed me almost nothing - 2-5 clicks and 2 minutes of my time

@nramirezuy yep, I can squash and rename commit

reformat files - proper spacing
@chekunkov chekunkov force-pushed the chekunkov:pydispatch_pep8 branch from 24f1f2c to 05cb31d Mar 16, 2015
@chekunkov
Copy link
Contributor Author

@chekunkov chekunkov commented Mar 16, 2015

@nramirezuy please tell if commit message looks better now

@nramirezuy nramirezuy changed the title Pydispatch pep8 [MRG+1]Pydispatch pep8 Mar 17, 2015
kmike added a commit that referenced this pull request Mar 17, 2015
Pydispatch pep8
@kmike kmike merged commit 62c4481 into scrapy:master Mar 17, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.